netdev - Re: [PATCH v3 20/21] phonet: exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 06 Nov 2017 21:37:05 +0200
From:   Rémi Denis-Courmont <remi@...lab.net>
To:     Vasily Averin <vvs@...tuozzo.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v3 20/21] phonet: exit_net cleanup check added

Le maanantaina 6. marraskuuta 2017, 16.25.54 EET Vasily Averin a écrit :
> Be sure that pndevs.list initialized in net_init hook was return
> to initial state.
> 
> Signed-off-by: Vasily Averin <vvs@...tuozzo.com>
> ---
>  net/phonet/pn_dev.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/net/phonet/pn_dev.c b/net/phonet/pn_dev.c
> index 2cb4c5d..f0ab85d 100644
> --- a/net/phonet/pn_dev.c
> +++ b/net/phonet/pn_dev.c
> @@ -331,7 +331,12 @@ static int __net_init phonet_init_net(struct net *net)
> 
>  static void __net_exit phonet_exit_net(struct net *net)
>  {
> +	struct phonet_net *pnn = phonet_pernet(net);
> +
>  	remove_proc_entry("phonet", net->proc_net);
> +	WARN_ONCE(!list_empty(&pnn->pndevs.list),
> +		  "net %x %s: pndevs.list is not empty\n",
> +		  net->ns.inum, __func__);
>  }
> 
>  static struct pernet_operations phonet_net_ops = {

In my opinon, tis is still utterly pointless. Really, what bug did this 
specific patch help to fix?

If you want to debug network namespaces, I have a feeling that the network 
namespace code is a better place to do so than individual protocol stacks.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/