netdev - Re: [PATCH 13/17] iwlwifi: mvm: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Nov 2017 12:40:11 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Luca Coelho <luca@...lho.fi>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        Johannes Berg <johannes.berg@...el.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        Sara Sharon <sara.sharon@...el.com>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH 13/17] iwlwifi: mvm: Convert timers to use timer_setup()

On Mon, Nov 6, 2017 at 11:48 AM, Luca Coelho <luca@...lho.fi> wrote:
> On Mon, 2017-11-06 at 11:45 -0800, Kees Cook wrote:
>> On Sun, Oct 29, 2017 at 5:28 AM, Luca Coelho <luca@...lho.fi> wrote:
>> > From: Kees Cook <keescook@...omium.org>
>> >
>> > In preparation for unconditionally passing the struct timer_list
>> > pointer to
>> > all timer callbacks, switch to using the new timer_setup() and
>> > from_timer()
>> > to pass the timer pointer explicitly.
>> >
>> > The RCU lifetime on baid_data is unclear, so this adds a direct
>> > copy of the
>> > rcu_ptr passed to the original callback. It may be possible to
>> > improve this
>> > to just use baid_data->mvm->baid_map[baid_data->baid] instead.
>> >
>> > Cc: Johannes Berg <johannes.berg@...el.com>
>> > Cc: Emmanuel Grumbach <emmanuel.grumbach@...el.com>
>> > Cc: Luca Coelho <luciano.coelho@...el.com>
>> > Cc: Intel Linux Wireless <linuxwifi@...el.com>
>> > Cc: Kalle Valo <kvalo@...eaurora.org>
>> > Cc: Sara Sharon <sara.sharon@...el.com>
>> > Cc: linux-wireless@...r.kernel.org
>> > Cc: netdev@...r.kernel.org
>> > Signed-off-by: Kees Cook <keescook@...omium.org>
>> > Signed-off-by: Luca Coelho <luciano.coelho@...el.com>
>> > ---
>> >  drivers/net/wireless/intel/iwlwifi/mvm/mvm.h  |  3 ++-
>> >  drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c |  4 ++--
>> >  drivers/net/wireless/intel/iwlwifi/mvm/sta.c  | 18 +++++++++----
>> > -----
>> >  3 files changed, 13 insertions(+), 12 deletions(-)
>>
>> Hi,
>>
>> Thanks for taking this! I had a question on timing: is this expected
>> to land for 4.15? If not, I would like to take this via the timers
>> tree, since it is one of the few remaining conversions.
>
> Hi Kees,
>
> Yes, this should land for 4.15.  Kalle just pulled my pull-request
> (which includes this) to wireless-drivers-next.  He told me he'll send
> a pull-request for 4.15 during this week and hopefully Dave will pull
> from him too.
>
> I'll let you know if something doesn't go as planned.

Awesome, thanks very much!

-Kees

-- 
Kees Cook
Pixel Security