netdev - Re: [PATCH] reduce the spinlock conflict during massive connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+yTbck6Oym5ZwizuuZ+VUsJYn_nUMR1z27K8n9ngRfdRFHQ+w@mail.gmail.com>
Date:   Mon, 6 Nov 2017 14:47:17 +0800
From:   Liu Yu <liuyu924@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "David S. Miller <davem@...emloft.net>,Alexey Kuznetsov
        <kuznet@....inr.ac.ru>,Hideaki YOSHIFUJI" <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH] reduce the spinlock conflict during massive connect

On Mon, Nov 6, 2017 at 12:12 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Sun, Nov 5, 2017 at 6:28 PM, Liu Yu <liuyu924@...il.com> wrote:
>> -               spin_lock_bh(&head->lock);
>> +               ret = spin_trylock(&head->lock);
>
> Clearly you want spin_trylock_bh() instead.

Good catch! Thansk!