netdev - Re: [PATCH ipsec-next] xfrm: don't pull esp/auth header in xfrm_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171106093803.GF23855@secunet.com>
Date:   Mon, 6 Nov 2017 10:38:03 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Florian Westphal <fw@...len.de>
CC:     <netdev@...r.kernel.org>
Subject: Re: [PATCH ipsec-next] xfrm: don't pull esp/auth header in
 xfrm_parse_spi

On Thu, Nov 02, 2017 at 01:54:10PM +0100, Florian Westphal wrote:
> syzbot reported an issue where pointer to ip header content was not
> reloaded after xfrm_parse_spi().
> 
> Its not intuitive that this function changes skb->head, so switch to
> skb_pointer_header.

I have to admit that this is not intuitive, but we pull
these headers later anyway. So using skb_header_pointer()
here might add another memcpy that could be avoided.

I think I'll stay with the fix you submitted for the ipsec
tree already.