netdev - Re: [PATCH net-next V3 0/3] tools: bpftool: show filenames of pinned objects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ad52dec-31f7-37e2-5110-c5e07a4024c2@netronome.com>
Date:   Mon, 6 Nov 2017 10:45:39 +0000
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Subject: Re: [PATCH net-next V3 0/3] tools: bpftool: show filenames of pinned
 objects

2017-11-06 15:06 UTC+0900 ~ Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
> This patchset adds support to show pinned objects in object details.
> 
> Patch1 adds a funtionality to open a path in bpf-fs regardless of its object
> type.
> 
> Patch2 adds actual functionality by scanning the bpf-fs once and adding
> object information in hash table, with object id as a key. One object may be
> associated with multiple paths because an object can be pinned multiple times
> 
> Patch3 adds command line option to enable this functionality. Making it optional
> because scanning bpf-fs can be costly.
> 
> v1->v2:
>  - Dynamically identify bpf-fs moutpoint
>  - Close files descriptors before returning on error
>  - Change command line option from {-l|--pinned} to {-f|--bpffs}
>  - Updated documentation
>  - Fixed line break for proper output formatting
>  - Code style: wrapped lines > 80, used reverse christmastree style
> 
> v2->v3:
>  - Handle multiple bpffs mountpoints
>  - Code style: fixed line break indentation
> 

Thanks for the changes! This version looks good to me.

Acked-by: Quentin Monnet <quentin.monnet@...ronome.com>