netdev - Re: [PATCH v3 01/21] grace: replace BUG_ON by WARN_ONCE in exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20171107122617.GB2260@avx2>
Date:   Tue, 7 Nov 2017 15:26:17 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     vvs@...tuozzo.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH v3 01/21] grace: replace BUG_ON by WARN_ONCE in exit_net
 hook

> -	BUG_ON(!list_empty(grace_list));
> +	WARN_ONCE(!list_empty(grace_list),
> +		  "net %x %s: grace_list is not empty\n",
> +		  net->ns.inum, __func__);

* printing __func__ is unnecessary as it will be on top of the stacktrace anyway,
* message duplicates condition
* printing netns id in netns ->exit hook also looks like pointless
  information: for kernel dumps you want struct net pointer right away.
  You wrote admins want to know which container triggered the message
  but what will they do with that information?

I'd say WARN_ONCE(!list_empty()) is enough.
BUG_ON if you ship with crashdumps by default.