netdev - Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mv3ynsw2.fsf@miraculix.mork.no>
Date:   Tue, 07 Nov 2017 14:02:53 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     Kristian Evensen <kristian.evensen@...il.com>
Cc:     netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

Kristian Evensen <kristian.evensen@...il.com> writes:

> When we receive a packet on a QMI device in raw IP mode, we should call
> skb_reset_mac_header() to ensure that skb->mac_header contains a valid
> offset in the packet. While it shouldn't really matter, the packets have
> no MAC header and the interface is configured as-such, it seems certain
> parts of the network stack expects a "good" value in skb->mac_header.

Thanks.  Yes, I see that the tun driver also does this.

Acked-by: Bjørn Mork <bjorn@...k.no>

And his should probably go to stable as well? with a

Fixes: 32f7adf633b9 ("net: qmi_wwan: support "raw IP" mode")