netdev - Re: [PATCH v3 2/2] selftests: bpf: test_kmod.sh: use modprobe on target device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a99822f-693e-6490-e320-187996e0cc74@osg.samsung.com>
Date:   Tue, 7 Nov 2017 10:10:07 -0700
From:   Shuah Khan <shuahkh@....samsung.com>
To:     naresh.kamboju@...aro.org, shuah@...nel.org,
        linux-kselftest@...r.kernel.org, daniel@...earbox.net,
        alexei.starovoitov@...il.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v3 2/2] selftests: bpf: test_kmod.sh: use modprobe on
 target device

On 11/07/2017 09:35 AM, naresh.kamboju@...aro.org wrote:
> From: Naresh Kamboju <naresh.kamboju@...aro.org>

Odd to see this From: line in the patch. Could you take a look
and see where this is coming from? Your gitconfig perhaps.

I have to fix this up when I apply the patch which I would like
to avoid.

> 
> On ARM and ARM64 devices kernel source tree is not available so
> insmod "$SRC_TREE/lib/test_bpf.ko" is not working.
> 
> On these target devices the test_bpf.ko is installed under
> /lib/modules/`uname -r`/kernel/lib/
> so use modprobe dry run to check for missing test_bpf.ko module and
> insert for testing.
> 
> Signed-off-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> ---
>  tools/testing/selftests/bpf/test_kmod.sh | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/tools/testing/selftests/bpf/test_kmod.sh b/tools/testing/selftests/bpf/test_kmod.sh
> index 2e5a1049e2f2..4757ca7d163c 100755
> --- a/tools/testing/selftests/bpf/test_kmod.sh
> +++ b/tools/testing/selftests/bpf/test_kmod.sh
> @@ -14,6 +14,16 @@ test_run()
>  		if [ $? -ne 0 ]; then
>  			rc=1
>  		fi
> +	else
> +		# Use modprobe dry run to check for missing test_bpf module
> +		if ! /sbin/modprobe -q -n test_bpf; then
> +			echo "test_bpf: [SKIP]"
> +		elif /sbin/modprobe -q test_bpf; then
> +			echo "test_bpf: ok"
> +		else
> +			echo "test_bpf: [FAIL]"
> +			rc=1
> +		fi
>  	fi
>  	rmmod  test_bpf 2> /dev/null
>  	dmesg | grep FAIL
> 

Okay now I am with you on the changes you are making in Patch v3 1/2 and
this one.

Please collapse these two patches into one or fix the SRC_TREE problem first
and then fix the missing module case.

I would like to get an Ack from net-dev folks before getting these in.
Alexei and Daniel! Please review and let me know if you good with this
change.

thanks,
-- Shuah