netdev - Re: [patch net-next 1/9] net_sch: red: Add offload ability to RED qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171107013943.qqac47yodas2n7qo@netronome.com>
Date:   Tue, 7 Nov 2017 10:39:45 +0900
From:   Simon Horman <simon.horman@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, nogahf@...lanox.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com, mlxsw@...lanox.com,
        andrew@...n.ch, vivien.didelot@...oirfairelinux.com,
        f.fainelli@...il.com, michael.chan@...adcom.com,
        ganeshgr@...lsio.com, saeedm@...lanox.com, matanb@...lanox.com,
        leonro@...lanox.com, idosch@...lanox.com,
        jakub.kicinski@...ronome.com, pieter.jansenvanvuuren@...ronome.com,
        john.hurley@...ronome.com, alexander.h.duyck@...el.com,
        ogerlitz@...lanox.com, john.fastabend@...il.com
Subject: Re: [patch net-next 1/9] net_sch: red: Add offload ability to RED
 qdisc

On Mon, Nov 06, 2017 at 07:23:41AM +0100, Jiri Pirko wrote:
> From: Nogah Frankel <nogahf@...lanox.com>
> 
> Add the ability to offload RED qdisc by using ndo_setup_tc.
> There are four commands for RED offloading:
> * TC_RED_SET: handles set and change.
> * TC_RED_DESTROY: handle qdisc destroy.
> * TC_RED_STATS: update the qdiscs counters (given as reference)
> * TC_RED_XSTAT: returns red xstats.
> 
> Whether RED is being offloaded is being determined every time dump action
> is being called because parent change of this qdisc could change its
> offload state but doesn't require any RED function to be called.
> 
> Signed-off-by: Nogah Frankel <nogahf@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Reviewed-by: Simon Horman <simon.horman@...ronome.com>