netdev - Re: [PATCH v3 net-next 5/5] net: dsa: switch: Don't add CPU port to an mdb by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adfcb503-2806-0c68-fd6a-d7d62b61a838@cogentembedded.com>
Date:   Tue, 7 Nov 2017 13:12:39 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH v3 net-next 5/5] net: dsa: switch: Don't add CPU port to
 an mdb by default

Hello!

On 11/7/2017 2:26 AM, Andrew Lunn wrote:

> Now that the host indicates when a multicast group should be forwarded
> from the switch to the host, don't do it by default.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---
>   net/dsa/switch.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/dsa/switch.c b/net/dsa/switch.c
> index e6c06aa349a6..e95722036a45 100644
> --- a/net/dsa/switch.c
> +++ b/net/dsa/switch.c
> @@ -121,7 +121,7 @@ static int dsa_switch_mdb_add(struct dsa_switch *ds,
>   	if (ds->index == info->sw_index)
>   		set_bit(info->port, group);
>   	for (port = 0; port < ds->num_ports; port++)
> -		if (dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port))
> +		if (dsa_is_dsa_port(ds, port))
>   			set_bit(port, group);
>   
>   	if (switchdev_trans_ph_prepare(trans)) {
> @@ -141,6 +141,7 @@ static int dsa_switch_mdb_add(struct dsa_switch *ds,
>   	return 0;
>   }
>   
> +
>   static int dsa_switch_mdb_del(struct dsa_switch *ds,
>   			      struct dsa_notifier_mdb_info *info)
>   {

    Unrelated whitespace change?

MBR, Sergei