netdev - Re: [PATCH net-next v6 3/3] act_vlan: VLAN action rewrite to use RCU lock/unlock and update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171108.090727.1485121667800460011.davem@davemloft.net>
Date:   Wed, 08 Nov 2017 09:07:27 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     alexander.duyck@...il.com
Cc:     pieter.jansenvanvuuren@...ronome.com, kurup.manish@...il.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        jakub.kicinski@...ronome.com, simon.horman@...ronome.com,
        john.hurley@...ronome.com, oss-drivers@...ronome.com,
        netdev@...r.kernel.org, aring@...atatu.com, mrv@...atatu.com,
        manish.kurup@...izon.com
Subject: Re: [PATCH net-next v6 3/3] act_vlan: VLAN action rewrite to use
 RCU lock/unlock and update

From: Alexander Duyck <alexander.duyck@...il.com>
Date: Tue, 7 Nov 2017 08:54:20 -0800

> Are we really going to be so strict about the reverse xmas-tree that
> we won't allow for assignment w/ variable declaration because the
> dependency order won't fit into that format?

Yes.

> Last I knew this kind of setup was an exception to the reverse
> xmas-tree layout requirement because in this case 'p' relies on 'v' so
> we can't reorder these without having to kick the assignment of 'p'
> off onto a line by itself.

Please just declare the variable naked without the assignment and do
the assignment down in the code.