netdev - Re: [PATCH 21/21] sunrpc: exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171108102205.55aa82eb@shemminger-XPS-13-9360>
Date:   Wed, 8 Nov 2017 10:22:05 +0900
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Vasily Averin <vvs@...tuozzo.com>
Cc:     netdev@...r.kernel.org, linux-nfs@...r.kernel.org,
        Anna Schumaker <anna.schumaker@...app.com>,
        Trond Myklebust <trond.myklebust@...marydata.com>,
        Jeff Layton <jlayton@...chiereds.net>,
        "J. Bruce Fields" <bfields@...ldses.org>
Subject: Re: [PATCH 21/21] sunrpc: exit_net cleanup check added

On Sun, 5 Nov 2017 13:02:44 +0300
Vasily Averin <vvs@...tuozzo.com> wrote:

> Be sure that all_clients list initialized in net_init hook was return
> to initial state.
> 
> Signed-off-by: Vasily Averin <vvs@...tuozzo.com>
> ---
>  net/sunrpc/sunrpc_syms.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/net/sunrpc/sunrpc_syms.c b/net/sunrpc/sunrpc_syms.c
> index c73de18..0c5a90f 100644
> --- a/net/sunrpc/sunrpc_syms.c
> +++ b/net/sunrpc/sunrpc_syms.c
> @@ -65,10 +65,14 @@ static __net_init int sunrpc_init_net(struct net *net)
>  
>  static __net_exit void sunrpc_exit_net(struct net *net)
>  {
> +	struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
> +
>  	rpc_pipefs_exit_net(net);
>  	unix_gid_cache_destroy(net);
>  	ip_map_cache_destroy(net);
>  	rpc_proc_exit(net);
> +	WARN(!list_empty(&sn->all_clients),
> +	     "net %p exit: sunrpc all_clients list is not empty\n", net);
>  }

Don't print a kernel pointer, this is a security leak.