netdev - Re: [PATCH v3 2/2] net: phy: leds: Add support for "link" trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171108.102521.1965425774011333434.davem@davemloft.net>
Date:   Wed, 08 Nov 2017 10:25:21 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     mail@...iej.szmigiero.name
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] net: phy: leds: Add support for "link" trigger

From: "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Date: Thu, 2 Nov 2017 00:49:18 +0100

> Currently, we create a LED trigger for any link speed known to a PHY.
> These triggers only fire when their exact link speed had been negotiated
> (they aren't cumulative, that is, they don't fire for "their or any higher"
> link speed).
> 
> What we are missing, however, is a trigger which will fire on any link
> speed known to the PHY. Such trigger can then be used for implementing a
> poor man's substitute of the "link" LED on boards that lack it.
> Let's add it.
> 
> Signed-off-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>

Also applied, thank you.