netdev - Re: [PATCH] net: mvpp2: Prevent userspace from changing TX affinities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171108.103156.136116035076396821.davem@davemloft.net>
Date:   Wed, 08 Nov 2017 10:31:56 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     marc.zyngier@....com
Cc:     thomas.petazzoni@...e-electrons.com,
        antoine.tenart@...e-electrons.com, netdev@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] net: mvpp2: Prevent userspace from changing TX
 affinities

From: Marc Zyngier <marc.zyngier@....com>
Date: Sat,  4 Nov 2017 12:33:47 +0000

> The mvpp2 driver can't cope at all with the TX affinities being
> changed from userspace, and spit an endless stream of
> 
> [   91.779920] mvpp2 f4000000.ethernet eth2: wrong cpu on the end of Tx processing
> [   91.779930] mvpp2 f4000000.ethernet eth2: wrong cpu on the end of Tx processing
> [   91.780402] mvpp2 f4000000.ethernet eth2: wrong cpu on the end of Tx processing
> [   91.780406] mvpp2 f4000000.ethernet eth2: wrong cpu on the end of Tx processing
> [   91.780415] mvpp2 f4000000.ethernet eth2: wrong cpu on the end of Tx processing
> [   91.780418] mvpp2 f4000000.ethernet eth2: wrong cpu on the end of Tx processing
> 
> rendering the box completely useless (I've measured around 600k
> interrupts/s on a 8040 box) once irqbalance kicks in and start
> doing its job.
> 
> Obviously, the driver was never designed with this in mind. So let's
> work around the problem by preventing userspace from interacting
> with these interrupts altogether.
> 
> Cc: stable@...r.kernel.org
> Signed-off-by: Marc Zyngier <marc.zyngier@....com>

Applied and queued up for -stable, thanks.