netdev - RE: [PATCH 0/9] use network namespace for iSCSI control interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Nov 2017 10:31:04 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Chris Leech' <cleech@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "containers@...ts.linux-foundation.org" 
        <containers@...ts.linux-foundation.org>
Subject: RE: [PATCH 0/9] use network namespace for iSCSI control interfaces

From: Chris Leech
> Sent: 07 November 2017 22:45
> 
> I've posted these changes to allow iSCSI management within a container
> using a network namespace to the SCSI and Open-iSCSI lists, but seeing
> as it's not really SCSI/block related I'm casting a wider net looking
> for reviews.

I didn't spot you acquiring and releasing references to the namespace.
(I might have missed it, the relevant patch is difficult to read).

If the sockets are created in the context of the process whose namespace
you are using you don't need it, but given the hooks and callbacks
I'm not at all sure that is obviously true.

	David