netdev - Re: [PATCH net-next 2/3] ip6_gre: Refactor ip6gre xmit codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALDO+SZAThL-qFvRC8w0So4DO03M3sxo5n=Xn=JkgoUPfhvgZg@mail.gmail.com>
Date:   Wed, 8 Nov 2017 05:06:57 -0800
From:   William Tu <u9012063@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/3] ip6_gre: Refactor ip6gre xmit codes

On Tue, Nov 7, 2017 at 6:10 PM, David Miller <davem@...emloft.net> wrote:
> From: William Tu <u9012063@...il.com>
> Date: Sun,  5 Nov 2017 10:39:04 -0800
>
>> diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
>> index 3e10c51e7e0c..8c7612f32926 100644
>> --- a/net/ipv6/ip6_gre.c
>> +++ b/net/ipv6/ip6_gre.c
>> @@ -497,6 +497,79 @@ static int gre_handle_offloads(struct sk_buff *skb, bool csum)
>>                                       csum ? SKB_GSO_GRE_CSUM : SKB_GSO_GRE);
>>  }
>>
>> +static inline void prepare_ip6gre_xmit_ipv4(struct sk_buff *skb,
>> +                                         struct net_device *dev,
>> +                                         struct flowi6 *fl6, __u8 *dsfield,
>> +                                         int *encap_limit)
>
> Please do not use 'inline' in foo.c files, let the compiler decide.
>
> Thank you.

Thanks. I will remove it and submit v2.
William