netdev - Re: [PATCH] ipv6: try not to take rtnl_lock in ip6mr_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1510162468.2849.109.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Wed, 08 Nov 2017 09:34:28 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Francesco Ruggeri <fruggeri@...sta.com>
Cc:     yoshfuji@...ux-ipv6.org, kuznet@....inr.ac.ru,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] ipv6: try not to take rtnl_lock in ip6mr_sk_done

On Wed, 2017-11-08 at 08:29 -0800, Francesco Ruggeri wrote:
> Any comments about this?
> The idea is to avoid traversing all mr6_tables (which requires
> the rtnl_lock) in ip6mr_sk_done(), when we know in advance
> that a match will not be found.
> This can happen when rawv6_close()/ip6mr_sk_done() is invoked
> on non-mroute6 sockets.

Please do not top post on netdev.

Most networking folks are in Seoul, attending netdev 2.2, having beers
and conversations together. Your patch can wait.

Also you did not provide the net or net-next tags.

Most applications do not open/close raw sockets often, so it is not
clear why we should try to optimize this slow path ?