netdev - Re: [PATCH net-next 0/3] net: flush neighbor entries when carrier is off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20171108.123943.438619569902500003.davem@davemloft.net>
Date:   Wed, 08 Nov 2017 12:39:43 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/3] net: flush neighbor entries when carrier
 is off

From: David Ahern <dsahern@...il.com>
Date: Wed, 8 Nov 2017 12:35:16 +0900

> On Mon, Nov 6, 2017 at 3:57 PM, David Ahern <dsahern@...il.com> wrote:
> 
>> Commit a6db4494d218c ("net: ipv4: Consider failed nexthops in multipath
>> routes") added support for checking neighbor state when selecting a path
>> for multipath route lookups. It works but incurs a delay waiting for
>> the neighbor entry to timeout. Improve the path selection by flushing
>> non-permanent neighbor entries when carrier is off.
>>
>> David Ahern (3):
>>   net: neigh: Add helper to flush entries on carrier down
>>   net: ipv4: flush neighbor entries when carrier is off
>>   net: ipv6: flush neighbor entries when carrier is off
>>
>>  include/net/neighbour.h |  1 +
>>  net/core/neighbour.c    | 26 ++++++++++++++++++++++----
>>  net/ipv4/fib_frontend.c |  7 +++++--
>>  net/ipv6/addrconf.c     |  3 +++
>>  4 files changed, 31 insertions(+), 6 deletions(-)
>>
>>
> Dave: please drop this set. It's not needed for the use case mentioned
> above, so at a minimum the commit message needs to be updated.

Yep, sure, no problem.