netdev - Re: [PATCH] bnxt: fix bnxt_hwrm_fw_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171108.134421.1202222154886319559.davem@davemloft.net>
Date:   Wed, 08 Nov 2017 13:44:21 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     michael.chan@...adcom.com, jiri@...lanox.com,
        sathya.perla@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bnxt: fix bnxt_hwrm_fw_set_time for y2038

From: Arnd Bergmann <arnd@...db.de>
Date: Mon,  6 Nov 2017 15:04:39 +0100

> On 32-bit architectures, rtc_time_to_tm() returns incorrect results
> in 2038 or later, and do_gettimeofday() is broken for the same reason.
> 
> This changes the code to use ktime_get_real_seconds() and time64_to_tm()
> instead, both of them are 2038-safe, and we can also get rid of the
> CONFIG_RTC_LIB dependency that way.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks Arnd.

The RTC_LIB dependency should have been done via KConfig anyways.