netdev - Re: [PATCH v2 net-next 0/6] mv88e6xxx broadcast flooding in hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171108.140138.85056790380753198.davem@davemloft.net>
Date:   Wed, 08 Nov 2017 14:01:38 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     netdev@...r.kernel.org, vivien.didelot@...oirfairelinux.com,
        f.fainelli@...il.com
Subject: Re: [PATCH v2 net-next 0/6] mv88e6xxx broadcast flooding in
 hardware

From: David Miller <davem@...emloft.net>
Date: Wed, 08 Nov 2017 13:58:09 +0900 (KST)

> From: Andrew Lunn <andrew@...n.ch>
> Date: Tue,  7 Nov 2017 00:02:25 +0100
> 
>> This patchset makes the mv88e6xxx driver perform flooding in hardware,
>> rather than let the software bridge perform the flooding. This is a
>> prerequisite for IGMP snooping on the bridge interface.
>> 
>> In order to make hardware broadcasting work, a few other issues need
>> fixing or improving. SWITCHDEV_ATTR_ID_PORT_PARENT_ID is broken, which
>> is apparent when testing on the ZII devel board with multiple
>> switches.
>> 
>> Some of these patches are taken from a previous RFC patchset of IGMP
>> support.
> 
> Series applied, thanks Andrew.

Hmmm, I think there might be some in-flight conflict with Vivien's recent
DSA refactoring.

net/dsa/slave.c: In function ‘dsa_slave_port_attr_get’:
net/dsa/slave.c:349:35: error: ‘struct dsa_switch_tree’ has no member named ‘tree’
   attr->u.ppid.id_len = sizeof(dst->tree);
                                   ^~
net/dsa/slave.c:350:32: error: ‘struct dsa_switch_tree’ has no member named ‘tree’
   memcpy(&attr->u.ppid.id, &dst->tree, attr->u.ppid.id_len);
                                ^~

Anyways, I had to revert, please fix this up and resubmit.

Thank you!