netdev - Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wp2z1phg.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
Date:   Thu, 09 Nov 2017 09:44:11 -0500
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     David Miller <davem@...emloft.net>, andrew@...n.ch
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com
Subject: Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

Hi David,

David Miller <davem@...emloft.net> writes:

> From: David Miller <davem@...emloft.net>
> Date: Thu, 09 Nov 2017 11:30:32 +0900 (KST)
>
>> Series applied, with the spurious whitespace change removed from patch
>> #5.
>
> Actually I had to revert, this doesn't build:
>
> net/dsa/slave.c: In function ‘dsa_slave_port_obj_add’:
> net/dsa/slave.c:311:26: warning: passing argument 1 of ‘dsa_port_mdb_add’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>    err = dsa_port_mdb_add(dp->cpu_dp, SWITCHDEV_OBJ_PORT_MDB(obj),
>                           ^~
> In file included from net/dsa/slave.c:26:0:
> net/dsa/dsa_priv.h:150:5: note: expected ‘struct dsa_port *’ but argument is of type ‘const struct dsa_port *’
>  int dsa_port_mdb_add(struct dsa_port *dp,
>      ^~~~~~~~~~~~~~~~
> net/dsa/slave.c: In function ‘dsa_slave_port_obj_del’:
> net/dsa/slave.c:340:26: warning: passing argument 1 of ‘dsa_port_mdb_del’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>    err = dsa_port_mdb_del(dp->cpu_dp, SWITCHDEV_OBJ_PORT_MDB(obj));
>                           ^~
> In file included from net/dsa/slave.c:26:0:
> net/dsa/dsa_priv.h:153:5: note: expected ‘struct dsa_port *’ but argument is of type ‘const struct dsa_port *’
>  int dsa_port_mdb_del(struct dsa_port *dp,
>      ^~~~~~~~~~~~~~~~
>   C-c C-cmake[3]: *** [scripts/Makefile.build:320: drivers/net/team/team.o] Interrupt

This patch series is passing cpu_dp to dsa_port_mdb_* which is const.
I have sent a revert patch to net-next to make it non-const again, so
patch series like this can be applied without compile error.


Thanks,

        Vivien