netdev - Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69896e07d730f8de13f7461b335f01b0@natalenko.name>
Date:   Fri, 10 Nov 2017 14:40:08 +0100
From:   Oleksandr Natalenko <oleksandr@...alenko.name>
To:     Yuchung Cheng <ycheng@...gle.com>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Roman Gushchin <guro@...com>, netdev <netdev@...r.kernel.org>,
        Neal Cardwell <ncardwell@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Lawrence Brakmo <brakmo@...com>
Subject: Re: [REGRESSION] Warning in tcp_fastretrans_alert() of
 net/ipv4/tcp_input.c

Uhh, sorry, just found the original submission [1].

[1] https://marc.info/?l=linux-netdev&m=151009763926816&w=2

10.11.2017 14:15, Oleksandr Natalenko wrote:
> Hi.
> 
> I'm running the machine with this patch applied for 7 hours now, and
> the warning hasn't appeared yet. Typically, it should be there within
> the first hour.
> 
> I'll keep an eye on it for a longer time, but as of now it looks good.
> 
> Some explanation on this please?
> 
> Thanks!
> 
> 06.11.2017 23:27, Yuchung Cheng wrote:
> ...snip...
>> hi guys can you try if the warning goes away w/ this quick fix?
>> 
>> 
>> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
>> index 0ada8bfc2ebd..072aab2a8226 100644
>> --- a/net/ipv4/tcp_input.c
>> +++ b/net/ipv4/tcp_input.c
>> @@ -2626,7 +2626,7 @@ void tcp_simple_retransmit(struct sock *sk)
>> 
>>         tcp_clear_retrans_hints_partial(tp);
>> 
>> -       if (prior_lost == tp->lost_out)
>> +       if (!tp->lost_out)
>>                 return;
>> 
>>         if (tcp_is_reno(tp))
> ...snip...