netdev - Re: [PATCH net-next 0/2] net: dsa: lan9303: IGMP handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49a8be62-683e-aac6-b3f3-eef7295a49ca@egil-hjelmeland.no>
Date:   Fri, 10 Nov 2017 19:22:11 +0100
From:   Egil Hjelmeland <privat@...l-hjelmeland.no>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 0/2] net: dsa: lan9303: IGMP handling



Den 10. nov. 2017 15:07, skrev Andrew Lunn:
>> skb->offload_fwd_mark calculation is a candidate for consolidation into the
>> DSA core. The calculation can probably be more polished when done at a point
>> where DSA has updated skb.
> 
> Hi Egil
> 
> Yes, at some point we should do this. But at the moment it is too
> early. We don't have enough experience with what the different
> switches need. I would like to see 4 or more devices doing it before
> we consolidate the code into the core.
> 

Absolutely. My point was rather I prefer not spend time polishing this 
snippet right now, because it will probably be refactored later anyway.

One steppingstone could be to make reusable helper-functions in 
net/dsa/dsa_priv.h. But I leave that to device #2 that implement this ;-)

> 	    Andrew
> 

Egil