netdev - Re: [PATCH net-next v7 0/3] nfp act_vlan: Rewrite of the TC vlan action to use the RCU, and incorporated review comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171110.145326.1999880909720356981.davem@davemloft.net>
Date:   Fri, 10 Nov 2017 14:53:26 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     kurup.manish@...il.com
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        jakub.kicinski@...ronome.com, pieter.jansenvanvuuren@...ronome.com,
        simon.horman@...ronome.com, john.hurley@...ronome.com,
        oss-drivers@...ronome.com, netdev@...r.kernel.org,
        aring@...atatu.com, mrv@...atatu.com, manish.kurup@...izon.com
Subject: Re: [PATCH net-next v7 0/3] nfp act_vlan: Rewrite of the TC vlan
 action to use the RCU, and incorporated review comments

From: Manish Kurup <kurup.manish@...il.com>
Date: Tue,  7 Nov 2017 08:50:00 -0500

> This commit consists of 3 patches:
> 
> patch1 (1/3):
> The VLAN action maintains one set of stats across all cores, and uses a
> spinlock to synchronize updates to it from the same. Changed this to use a
> per-CPU stats context instead.
> This change will result in better performance.
> 
> patch2 (2/3):
> Modified netronome nfp flower action to use VLAN helper functions instead
> of accessing/referencing TC act_vlan private structures directly. 
> 
> patch3 (3/3):
> Using a spinlock in the VLAN action causes performance issues when the VLAN
> action is used on multiple cores. Rewrote the VLAN action to use RCU read
> locking for reads and updates instead.
> All functions now use an RCU dereferenced pointer to access the VLAN action
> context. Modified helper functions used by other modules, to use the RCU as
> opposed to directly accessing the structure.
> 
> As part of this review, there were some changes suggested by reviewers.
> I have incorporated all the changes that were requested.
 ...

Series applied, thank you.