netdev - Re: [PATCH] net: ipv6: sysctl to specify IPv6 ND traffic class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 11 Nov 2017 15:13:26 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     zenczykowski@...il.com
Cc:     maze@...gle.com, netdev@...r.kernel.org, lorenzo@...gle.com,
        ek@...gle.com
Subject: Re: [PATCH] net: ipv6: sysctl to specify IPv6 ND traffic class

From: Maciej Żenczykowski <zenczykowski@...il.com>
Date: Tue,  7 Nov 2017 21:52:09 -0800

> From: Maciej Żenczykowski <maze@...gle.com>
> 
> Add a per-device sysctl to specify the default traffic class to use for
> kernel originated IPv6 Neighbour Discovery packets.
> 
> Currently this includes:
> 
>   - Router Solicitation (ICMPv6 type 133)
>     ndisc_send_rs() -> ndisc_send_skb() -> ip6_nd_hdr()
> 
>   - Neighbour Solicitation (ICMPv6 type 135)
>     ndisc_send_ns() -> ndisc_send_skb() -> ip6_nd_hdr()
> 
>   - Neighbour Advertisement (ICMPv6 type 136)
>     ndisc_send_na() -> ndisc_send_skb() -> ip6_nd_hdr()
> 
>   - Redirect (ICMPv6 type 137)
>     ndisc_send_redirect() -> ndisc_send_skb() -> ip6_nd_hdr()
> 
> and if the kernel ever gets around to generating RA's,
> it would presumably also include:
> 
>   - Router Advertisement (ICMPv6 type 134)
>     (radvd daemon could pick up on the kernel setting and use it)
> 
> Interface drivers may examine the Traffic Class value and translate
> the DiffServ Code Point into a link-layer appropriate traffic
> prioritization scheme.  An example of mapping IETF DSCP values to
> IEEE 802.11 User Priority values can be found here:
> 
>     https://tools.ietf.org/html/draft-ietf-tsvwg-ieee-802-11
> 
> The expected primary use case is to properly prioritize ND over wifi.
> 
> Testing:
 ...
> (based on original change written by Erik Kline, with minor changes)
> 
> v2: fix 'suspicious rcu_dereference_check() usage'
>     by explicitly grabbing the rcu_read_lock.
> 
> Cc: Lorenzo Colitti <lorenzo@...gle.com>
> Signed-off-by: Erik Kline <ek@...gle.com>
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>

Applied to net-next, thanks.