netdev - Re: [PATCH net-next] net: mvpp2: fix GOP statistics loop start and stop conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 11 Nov 2017 15:21:44 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     miquel.raynal@...e-electrons.com
Cc:     thomas.petazzoni@...e-electrons.com,
        gregory.clement@...e-electrons.com,
        antoine.tenart@...e-electrons.com, nadavh@...vell.com,
        netdev@...r.kernel.org, stefanc@...vell.com, f.fainelli@...il.com,
        andrew@...n.ch
Subject: Re: [PATCH net-next] net: mvpp2: fix GOP statistics loop start and
 stop conditions

From: Miquel Raynal <miquel.raynal@...e-electrons.com>
Date: Wed,  8 Nov 2017 08:59:40 +0100

> GOP statistics from all ports of one instance of the driver are gathered
> with one work recalled in loop in a workqueue. The loop is started when
> a port is up, and stopped when a port is down. This last condition is
> obviously wrong.
> 
> Fix this by having a work per port. This way, starting and stoping it
> when the port is up or down will be fine, while minimizing unnecessary
> CPU usage.
> 
> Fixes: 118d6298f6f0 ("net: mvpp2: add ethtool GOP statistics")
> Reported-by: Stefan Chulski <stefanc@...vell.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@...e-electrons.com>

Applied.