netdev - Re: [PATCH v2 net-next 1/3] netem: convert to qdisc_watchdog_schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 11 Nov 2017 20:28:42 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Dave Taht <dave.taht@...il.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        stephen@...workplumber.org, Dave Taht <dave.taht@...il.com>
Subject: Re: [PATCH v2 net-next 1/3] netem: convert to
 qdisc_watchdog_schedule_ns

Hi Dave,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Dave-Taht/netem-convert-to-qdisc_watchdog_schedule_ns/20171111-184934
config: i386-randconfig-i1-201745 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   net/sched/sch_netem.o: In function `netem_enqueue':
>> net/sched/sch_netem.c:323: undefined reference to `__moddi3'

vim +323 net/sched/sch_netem.c

661b7972 stephen hemminger 2011-02-23  302  
661b7972 stephen hemminger 2011-02-23  303  
^1da177e Linus Torvalds    2005-04-16  304  /* tabledist - return a pseudo-randomly distributed value with mean mu and
^1da177e Linus Torvalds    2005-04-16  305   * std deviation sigma.  Uses table lookup to approximate the desired
^1da177e Linus Torvalds    2005-04-16  306   * distribution, and a uniformly-distributed pseudo-random source.
^1da177e Linus Torvalds    2005-04-16  307   */
9d0cec66 Dave Taht         2017-11-08  308  static s64 tabledist(s64 mu, s64 sigma,
b407621c Stephen Hemminger 2007-03-22  309  		     struct crndstate *state,
b407621c Stephen Hemminger 2007-03-22  310  			 const struct disttable *dist)
^1da177e Linus Torvalds    2005-04-16  311  {
9d0cec66 Dave Taht         2017-11-08  312  	s64 x;
b407621c Stephen Hemminger 2007-03-22  313  	long t;
b407621c Stephen Hemminger 2007-03-22  314  	u32 rnd;
^1da177e Linus Torvalds    2005-04-16  315  
^1da177e Linus Torvalds    2005-04-16  316  	if (sigma == 0)
^1da177e Linus Torvalds    2005-04-16  317  		return mu;
^1da177e Linus Torvalds    2005-04-16  318  
^1da177e Linus Torvalds    2005-04-16  319  	rnd = get_crandom(state);
^1da177e Linus Torvalds    2005-04-16  320  
^1da177e Linus Torvalds    2005-04-16  321  	/* default uniform distribution */
^1da177e Linus Torvalds    2005-04-16  322  	if (dist == NULL)
^1da177e Linus Torvalds    2005-04-16 @323  		return (rnd % (2*sigma)) - sigma + mu;
^1da177e Linus Torvalds    2005-04-16  324  
^1da177e Linus Torvalds    2005-04-16  325  	t = dist->table[rnd % dist->size];
^1da177e Linus Torvalds    2005-04-16  326  	x = (sigma % NETEM_DIST_SCALE) * t;
^1da177e Linus Torvalds    2005-04-16  327  	if (x >= 0)
^1da177e Linus Torvalds    2005-04-16  328  		x += NETEM_DIST_SCALE/2;
^1da177e Linus Torvalds    2005-04-16  329  	else
^1da177e Linus Torvalds    2005-04-16  330  		x -= NETEM_DIST_SCALE/2;
^1da177e Linus Torvalds    2005-04-16  331  
^1da177e Linus Torvalds    2005-04-16  332  	return  x / NETEM_DIST_SCALE + (sigma / NETEM_DIST_SCALE) * t + mu;
^1da177e Linus Torvalds    2005-04-16  333  }
^1da177e Linus Torvalds    2005-04-16  334  

:::::: The code at line 323 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (34923 bytes)