netdev - Re: [PATCHv2 net-next 1/3] ip_gre: Refector the erpsan tunnel code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALDO+SYNCbfpgkM142ixYvrQwjQUKLP1ePYsR_3mGJ60Ja8U9A@mail.gmail.com>
Date:   Mon, 13 Nov 2017 07:14:29 -0800
From:   William Tu <u9012063@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCHv2 net-next 1/3] ip_gre: Refector the erpsan tunnel code.

On Sat, Nov 11, 2017 at 2:07 AM, David Miller <davem@...emloft.net> wrote:
> From: William Tu <u9012063@...il.com>
> Date: Wed,  8 Nov 2017 16:13:02 -0800
>
>> +static void erspan_build_header(struct sk_buff *skb,
>> +                             __be32 id, u32 index,
>> +                             bool truncate, bool is_ipv4)
>> +{
>
> Please do not put large non-inline functions into header files.

Thanks. I will make it inline in the next version.