netdev - Re: [RFC] hv_netvsc: safer orderly shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171113092253.68dd8ae1@xeon-e3>
Date:   Mon, 13 Nov 2017 09:22:53 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:     David Miller <davem@...emloft.net>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        eric.dumazet@...il.com, netdev@...r.kernel.org,
        haiyangz@...rosoft.com, linux-kernel@...r.kernel.org,
        devel@...uxdriverproject.org
Subject: Re: [RFC] hv_netvsc: safer orderly shutdown

On Mon, 13 Nov 2017 11:57:47 +0100
Vitaly Kuznetsov <vkuznets@...hat.com> wrote:

> Stephen Hemminger <stephen@...workplumber.org> writes:
> 
> >
> > The NAPI disable is already handled by rndis close.  
> 
> Sorry, but I'm probably missing something: I can only see
> netif_napi_del() call in netvsc_device_remove() but this happens much
> later. And I don see us doing napi_disable() anywhere on the path.
> But I'm probably missing something.
> 

You need to keep NAPI running to handle transmit completions.
Disabling the Tx and Rx filter should keep spurious activity
away until the halt is done.