netdev - Re: [patch 1/1] net/sched/sch_red.c: work around gcc-4.4.4 anon union initializer issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171113.103420.2196749484231702778.davem@davemloft.net>
Date:   Mon, 13 Nov 2017 10:34:20 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     akpm@...ux-foundation.org
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, nogahf@...lanox.com,
        simon.horman@...ronome.com
Subject: Re: [patch 1/1] net/sched/sch_red.c: work around gcc-4.4.4 anon
 union initializer issue

From: akpm@...ux-foundation.org
Date: Fri, 10 Nov 2017 15:09:53 -0800

> From: Andrew Morton <akpm@...ux-foundation.org>
> Subject: net/sched/sch_red.c: work around gcc-4.4.4 anon union initializer issue
> 
> gcc-4.4.4 (at lest) has issues with initializers and anonymous unions:
> 
> net/sched/sch_red.c: In function 'red_dump_offload':
> net/sched/sch_red.c:282: error: unknown field 'stats' specified in initializer
> net/sched/sch_red.c:282: warning: initialization makes integer from pointer without a cast
> net/sched/sch_red.c:283: error: unknown field 'stats' specified in initializer
> net/sched/sch_red.c:283: warning: initialization makes integer from pointer without a cast
> net/sched/sch_red.c: In function 'red_dump_stats':
> net/sched/sch_red.c:352: error: unknown field 'xstats' specified in initializer
> net/sched/sch_red.c:352: warning: initialization makes integer from pointer without a cast
> 
> Work around this.
> 
> Fixes: 602f3baf2218 ("net_sch: red: Add offload ability to RED qdisc")
> Cc: Nogah Frankel <nogahf@...lanox.com>
> Cc: Jiri Pirko <jiri@...lanox.com>
> Cc: Simon Horman <simon.horman@...ronome.com>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Applied.