netdev - Re: [PATCH net-next 0/5] net: improve the process of redirect and toobig for ipv6 tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171113.104424.128551617270173532.davem@davemloft.net>
Date:   Mon, 13 Nov 2017 10:44:24 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, yasuyuki.kozakai@...hiba.co.jp, xeb@...l.ru
Subject: Re: [PATCH net-next 0/5] net: improve the process of redirect and
 toobig for ipv6 tunnels

From: Xin Long <lucien.xin@...il.com>
Date: Sat, 11 Nov 2017 19:06:48 +0800

> Now let's say there are 3 kinds of icmp packets to process for tunnels,
> toobig(needfrag), redirect, others, their process should be:
> 
>  - toobig(needfrag)
>    update the lower dst's pmtu by route cache, also update sk dst's pmtu
>    if possible, or it will be fine if sk dst pmtu will get updated on tx
>    path.
> 
>  - redirect
>    update the lower dst's gw by route cache and return, no need to send
>    this redirect packet to user sk.
> 
>  - others
>    send the packet to user's sk, or it will also be fine to use err_count
>    to count it and report fail link on tx path.
> 
> All ipv4 tunnels basically follow this while some of ipv6 tunnels are
> doing in different ways, like ip6gre and ip6_tunnels update tnl dev's
> mtu instead of updating lower dst pmtu, no redirect process on their
> err_handlers, which doesn't make any sense and even causes performance
> problems.
> 
> This patchset is to improve the process of redirect and toobig for ip6gre
> ip4ip6, ip6ip6 tunnels, as in ipv4 tunnels.

Series applied, thank you.