netdev - Re: [patch net-next v2 04/10] net: sched: introduce block mechanism to handle netif_keep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171113000334.1ebb5d28@cakuba>
Date:   Mon, 13 Nov 2017 00:03:34 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jhs@...atatu.com,
        xiyou.wangcong@...il.com, mlxsw@...lanox.com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        ast@...nel.org, daniel@...earbox.net, simon.horman@...ronome.com,
        pieter.jansenvanvuuren@...ronome.com, john.hurley@...ronome.com
Subject: Re: [patch net-next v2 04/10] net: sched: introduce block mechanism
 to handle netif_keep_dst calls

On Mon, 13 Nov 2017 08:58:44 +0100, Jiri Pirko wrote:
> Mon, Nov 13, 2017 at 08:47:26AM CET, jakub.kicinski@...ronome.com wrote:
> >On Sun, 12 Nov 2017 16:55:58 +0100, Jiri Pirko wrote:  
> >> From: Jiri Pirko <jiri@...lanox.com>
> >> 
> >> Couple of classifiers call netif_keep_dst directly on q->dev. That is
> >> not possible to do directly for shared blocke where multiple qdiscs are
> >> owning the block. So introduce a infrastructure to keep track of the
> >> block owners in list and use this list to implement block variant of
> >> netif_keep_dst.
> >> 
> >> Signed-off-by: Jiri Pirko <jiri@...lanox.com>  
> >
> >Could you use the list you add here to check the ethtool tc offload
> >flag? :)  
> 
> It is a list of qdisc sub parts. Not a list of netdevs

Hm.  OK, I won't pretend I understand the TC code in detail, I thought
that would give you all netdevs, but possibly duplicated.