netdev - Re: [PATCH net-next] net: dsa: Fix dependencies on bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171114.111209.1897869835074017989.davem@davemloft.net>
Date:   Tue, 14 Nov 2017 11:12:09 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     netdev@...r.kernel.org, vivien.didelot@...oirfairelinux.com,
        f.fainelli@...il.com
Subject: Re: [PATCH net-next] net: dsa: Fix dependencies on bridge

From: Andrew Lunn <andrew@...n.ch>
Date: Sat, 11 Nov 2017 16:29:41 +0100

> DSA now uses one of the symbols exported by the bridge,
> br_vlan_enabled(). This has a stub, if the bridge is not
> enabled. However, if the bridge is enabled, we cannot have DSA built
> in and the bridge as a module, otherwise we get undefined symbols at
> link time:
> 
>    net/dsa/port.o: In function `dsa_port_vlan_add':
>    net/dsa/port.c:255: undefined reference to `br_vlan_enabled'
>    net/dsa/port.o: In function `dsa_port_vlan_del':
>    net/dsa/port.c:270: undefined reference to `br_vlan_enabled'
> 
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied, thanks Andrew.