netdev - Re: [PATCH v3 4/4] net: nb8800: Add support for suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83c8a08a-f369-0bd0-67dd-6c6678ce5ef0@sigmadesigns.com>
Date:   Tue, 14 Nov 2017 18:08:47 +0100
From:   Marc Gonzalez <marc_gonzalez@...madesigns.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Mans Rullgard <mans@...sr.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Mason <slash.tmp@...e.fr>, netdev <netdev@...r.kernel.org>,
        Thibaud Cornic <thibaud_cornic@...madesigns.com>,
        David Miller <davem@...emloft.net>,
        "Linux ARM" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 4/4] net: nb8800: Add support for suspend/resume

On 14/11/2017 17:31, Andrew Lunn wrote:

> On Tue, Nov 14, 2017 at 03:22:04PM +0100, Marc Gonzalez wrote:
> 
>> On 14/11/2017 14:02, Måns Rullgård wrote:
>>
>>> Missing patch description.  Don't bother though.  I won't approve of
>>> this implementation.
>>
>> I hope I can convince David that you should not have veto power over
>> this driver just because it was you who submitted it upstream first.
> 
> In practice, anybody can request a veto on a patch. If a patch
> introduces a regression, and somebody reports it, that is pretty much
> an automatic veto.
> 
> Please work with Mans to ensure you are not breaking the driver for
> the hardware he cares about.

FWIW, removing generic support ("aurora,nb8800") does not break any existing hardware.

The ethernet controller in the board Mans uses is supported by "sigma,smp8642-ethernet".

I can't test my exact changes on a similar board because support for that board
is not (yet?) upstream.