netdev - Re: Broken netlink ABI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5c84800-eb04-9ac2-9428-34e366002d15@gmail.com>
Date:   Tue, 14 Nov 2017 13:15:01 -0700
From:   David Ahern <dsahern@...il.com>
To:     Jon Maloy <jon.maloy@...csson.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "David Miller (davem@...emloft.net)" <davem@...emloft.net>
Subject: Re: Broken netlink ABI

On 11/14/17 12:19 PM, Jon Maloy wrote:
> When I give the command:
> ~$ tipc node set addr 1.1.2
> 
> I get the following response:
> 
> error: Numerical result out of range
> Unable to get TIPC nl family id (module loaded?)
> error, message initialisation failed

tipc is sending a u32 for the family attribute when it should be a u16:

diff --git a/tipc/msg.c b/tipc/msg.c
index 22c22226bb20..dc09d05048f3 100644
--- a/tipc/msg.c
+++ b/tipc/msg.c
@@ -125,7 +125,7 @@ static int get_family(void)
        genl->cmd = CTRL_CMD_GETFAMILY;
        genl->version = 1;

-       mnl_attr_put_u32(nlh, CTRL_ATTR_FAMILY_ID, GENL_ID_CTRL);
+       mnl_attr_put_u16(nlh, CTRL_ATTR_FAMILY_ID, GENL_ID_CTRL);
        mnl_attr_put_strz(nlh, CTRL_ATTR_FAMILY_NAME, TIPC_GENL_V2_NAME);

        if ((err = msg_query(nlh, family_id_cb, &nl_family)))

With the above change the tipc command runs fine.