netdev - Re: [PATCH net] vxlan: fix the issue that neigh proxy blocks all icmpv6 packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171114.161328.1796009670844190871.davem@davemloft.net>
Date:   Tue, 14 Nov 2017 16:13:28 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com, vincent@...nat.im
Subject: Re: [PATCH net] vxlan: fix the issue that neigh proxy blocks all
 icmpv6 packets

From: Xin Long <lucien.xin@...il.com>
Date: Sat, 11 Nov 2017 19:58:50 +0800

> Commit f1fb08f6337c ("vxlan: fix ND proxy when skb doesn't have transport
> header offset") removed icmp6_code and icmp6_type check before calling
> neigh_reduce when doing neigh proxy.
> 
> It means all icmpv6 packets would be blocked by this, not only ns packet.
> In Jianlin's env, even ping6 couldn't work through it.
> 
> This patch is to bring the icmp6_code and icmp6_type check back and also
> removed the same check from neigh_reduce().
> 
> Fixes: f1fb08f6337c ("vxlan: fix ND proxy when skb doesn't have transport header offset")
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable, thanks.