netdev - Re: [PATCH] ibmveth: Kernel crash LSO offload flag toggle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wp2t3byi.fsf@linkitivity.dja.id.au>
Date:   Tue, 14 Nov 2017 12:07:01 +1100
From:   Daniel Axtens <dja@...ens.net>
To:     "Bryant G. Ly" <bryantly@...ux.vnet.ibm.com>,
        benh@...nel.crashing.org, paulus@...ba.org, mpe@...erman.id.au,
        tlfalcon@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        stable@...r.kernel.org,
        "Bryant G. Ly" <bryantly@...ux.vnet.ibm.com>
Subject: Re: [PATCH] ibmveth: Kernel crash LSO offload flag toggle

Hi Bryant,

A few things:

1) The commit message could probably be trimmed, especially the stack
traces.

2) What exactly are you changing and why does it fix the issue? I
couldn't figure that out from the commit message.

3) Does this need a Fixes: tag?

>  	}
>  
> -	netdev->min_mtu = IBMVETH_MIN_MTU;
> -	netdev->max_mtu = ETH_MAX_MTU;
> -

4) What does the above hunk do? It seems unrelated...

Regards,
Daniel