netdev - Re: [ovs-dev] [PATCH net-next] openvswitch: Fix return value check in ovs_meter_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_Cfy-g==Rb6+vmY+9dvGAybQ+7a6AH+FydPCqigB7iqzw@mail.gmail.com>
Date:   Tue, 14 Nov 2017 16:27:04 +0530
From:   Pravin Shelar <pshelar@....org>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Pravin Shelar <pshelar@...ira.com>, Andy Zhou <azhou@....org>,
        ovs dev <dev@...nvswitch.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [ovs-dev] [PATCH net-next] openvswitch: Fix return value check in ovs_meter_cmd_features()

On Tue, Nov 14, 2017 at 11:50 AM, Wei Yongjun <weiyongjun1@...wei.com> wrote:
> In case of error, the function ovs_meter_cmd_reply_start() returns
> ERR_PTR() not NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Fixes: 96fbc13d7e77 ("openvswitch: Add meter infrastructure")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Acked-by: Pravin B Shelar <pshelar@....org>