netdev - Re: [PATCH v2 net-next] socket: Move the socket inuse to namespace.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMDZJNXNB+owLY52tep8=rog8D8UonH57bYJfBY9EnXA9HtEfw@mail.gmail.com>
Date:   Wed, 15 Nov 2017 23:15:04 +0800
From:   Tonghao Zhang <xiangxia.m.yue@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     张军伟(基础平台部) 
        <zhangjunweimartin@...ichuxing.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        张同浩(基础平台部) 
        <zhangtonghao@...ichuxing.com>
Subject: Re: [PATCH v2 net-next] socket: Move the socket inuse to namespace.

On Wed, Nov 15, 2017 at 12:48 AM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Tue, Nov 14, 2017 at 3:17 AM, Tonghao Zhang <xiangxia.m.yue@...il.com> wrote:
>> Hi cong, we increase the socket inuse in sk_allock ?
>
> How about sock_init_data()?
>
> Or at least you can replace get_net() with read_pnet()?
Hi cong, I guess it is better to count socket inuse in sk_alloc. It is
easy to maintain counter. In this way, we dont hold the refcnt again.
I send the v3. Can you review it again ? thanks.