[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20171115233343.GA28812@electric-eye.fr.zoreil.com>
Date: Thu, 16 Nov 2017 00:33:43 +0100
From: Francois Romieu <romieu@...zoreil.com>
To: David Miller <davem@...emloft.net>
Cc: kai.heng.feng@...onical.com, nic_swsd@...ltek.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
hayeswang@...ltek.com, jrg.otte@...il.com
Subject: Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving
David Miller <davem@...emloft.net> :
[...]
> The amount of coverage this change is going to get is very small as
> well, meaning an even greater chance of regressions.
Yes.
> Therefore the only acceptable way to handle this is to have
> a white-list, specific chips that have been explicitly tested
> and are known to work with this feature, rather than the other
> way around.
>
> Furthermore, you're not even checking the chip version, you're
> checking instead whether the firmware is loaded or not. That
> doesn't seem like a safe way to guard this at all.
Actually the chip specific xyz_hw_phy_config methods call the relevant
aldps enabling helper _but_ the 8168evl dedicated xyz_hw_phy_config
doesn't. The firmware loaded check is just a distraction for the
busy reviewer.
--
Ueimor
Powered by blists - more mailing lists