netdev - Re: [PATCH net-next] tcp: highest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171115.194911.981451129115154627.davem@davemloft.net>
Date:   Wed, 15 Nov 2017 19:49:11 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, ycheng@...gle.com
Subject: Re: [PATCH net-next] tcp: highest_sack fix

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 14 Nov 2017 21:02:19 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> syzbot easily found a regression added in our latest patches [1]
> 
> No longer set tp->highest_sack to the head of the send queue since
> this is not logical and error prone.
> 
> Only sack processing should maintain the pointer to an skb from rtx queue.
> 
> We might in the future only remember the sequence instead of a pointer to skb,
> since rb-tree should allow a fast lookup.
 ...
> Fixes: 737ff314563c ("tcp: use sequence distance to detect reordering")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Yuchung Cheng <ycheng@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied.