netdev - Re: [PATCH] [net-next,v2] ibmvnic: fix dma_mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <22ff4956-84b4-ed2d-8fa2-2ed3c4333796@linux.vnet.ibm.com>
Date:   Thu, 16 Nov 2017 17:53:20 -0200
From:   Desnes Augusto Nunes do Rosário 
        <desnesn@...ux.vnet.ibm.com>
To:     netdev@...r.kernel.org
Cc:     linuxppc-dev@...ts.ozlabs.org, tlfalcon@...ux.vnet.ibm.com,
        nfont@...ux.vnet.ibm.com, jallen@...ux.vnet.ibm.com
Subject: Re: [PATCH] [net-next,v2] ibmvnic: fix dma_mapping_error call

First of all, I apologize for sending this patch to net-next!

Since this is a fix, it should had been sent to the regular net tree, 
which I'll do now with the proper fixes tag. My mistake!

Thanks for understanding and please discard this one.

On 11/16/2017 04:33 PM, Desnes Augusto Nunes do Rosario wrote:
> This patch fixes the dma_mapping_error call to use the correct dma_addr
> which is inside the ibmvnic_vpd struct. Moreover, it fixes a uninitialized
>   warning for the local dma_addr.
> 
> Signed-off-by: Desnes A. Nunes do Rosario <desnesn@...ux.vnet.ibm.com>
> ---
>   drivers/net/ethernet/ibm/ibmvnic.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index 04aaacb..1dc4aef 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -849,7 +849,6 @@ static int ibmvnic_get_vpd(struct ibmvnic_adapter *adapter)
>   {
>   	struct device *dev = &adapter->vdev->dev;
>   	union ibmvnic_crq crq;
> -	dma_addr_t dma_addr;
>   	int len = 0;
> 
>   	if (adapter->vpd->buff)
> @@ -879,7 +878,7 @@ static int ibmvnic_get_vpd(struct ibmvnic_adapter *adapter)
>   	adapter->vpd->dma_addr =
>   		dma_map_single(dev, adapter->vpd->buff, adapter->vpd->len,
>   			       DMA_FROM_DEVICE);
> -	if (dma_mapping_error(dev, dma_addr)) {
> +	if (dma_mapping_error(dev, adapter->vpd->dma_addr)) {
>   		dev_err(dev, "Could not map VPD buffer\n");
>   		kfree(adapter->vpd->buff);
>   		return -ENOMEM;
> 

-- 
Desnes Augusto Nunes do Rosário
------------------------------------------

Linux Developer - IBM / Brazil
M.Sc. in Electrical and Computer Engineering - UFRN

(11) 9595-30-900
desnesn@...ibm.com