netdev - Re: [PATCH net-next] netfilter: add ifdef around ctnetlink_proto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171116.105041.804470304446588046.davem@davemloft.net>
Date:   Thu, 16 Nov 2017 10:50:41 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     pablo@...filter.org
Cc:     netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
        arnd@...db.de
Subject: Re: [PATCH net-next] netfilter: add ifdef around
 ctnetlink_proto_size

From: Pablo Neira Ayuso <pablo@...filter.org>
Date: Wed, 15 Nov 2017 18:28:21 +0100

> From: Arnd Bergmann <arnd@...db.de>
> 
> This function is no longer marked 'inline', so we now get a warning
> when it is unused:
> 
> net/netfilter/nf_conntrack_netlink.c:536:15: error: 'ctnetlink_proto_size' defined but not used [-Werror=unused-function]
> 
> We could mark it inline again, mark it __maybe_unused, or add an #ifdef
> around the definition. I'm picking the third approach here since that
> seems to be what the rest of the file has.
> 
> Fixes: 5caaed151a68 ("netfilter: conntrack: don't cache nlattr_tuple_size result in nla_size")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>

Applied.