netdev - Re: [PATCH v2 2/2] chcr: Add support for Inline IPSec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Nov 2017 13:19:52 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Atul Gupta <atul.gupta@...lsio.com>
Cc:     kbuild-all@...org, herbert@...dor.apana.org.au,
        linux-crypto@...r.kernel.org, netdev@...r.kernel.org,
        steffen.klassert@...unet.com, Harsh Jain <harsh@...lsio.com>,
        Ganesh Goudar <ganeshgr@...lsio.com>
Subject: Re: [PATCH v2 2/2] chcr: Add support for Inline IPSec

Hi Atul,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on cryptodev/master]
[also build test ERROR on next-20171115]
[cannot apply to v4.14]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Atul-Gupta/cxgb4-Add-support-for-Inline-IPSec-Tx/20171112-012558
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: x86_64-randconfig-g0-11160917 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/crypto/chelsio/chcr_core.o: In function `chcr_uld_tx_handler':
>> drivers/crypto/chelsio/chcr_core.c:195: undefined reference to `chcr_ipsec_xmit'
   drivers/crypto/chelsio/chcr_core.o: In function `chcr_uld_add':
>> drivers/crypto/chelsio/chcr_core.c:169: undefined reference to `chcr_add_xfrmops'

vim +195 drivers/crypto/chelsio/chcr_core.c

   152	
   153	static void *chcr_uld_add(const struct cxgb4_lld_info *lld)
   154	{
   155		struct uld_ctx *u_ctx;
   156	
   157		/* Create the device and add it in the device list */
   158		if (!(lld->ulp_crypto & ULP_CRYPTO_LOOKASIDE))
   159			return ERR_PTR(-EOPNOTSUPP);
   160	
   161		/* Create the device and add it in the device list */
   162		u_ctx = kzalloc(sizeof(*u_ctx), GFP_KERNEL);
   163		if (!u_ctx) {
   164			u_ctx = ERR_PTR(-ENOMEM);
   165			goto out;
   166		}
   167		u_ctx->lldi = *lld;
   168		if (lld->crypto & ULP_CRYPTO_IPSEC_INLINE)
 > 169			chcr_add_xfrmops(lld);
   170	out:
   171		return u_ctx;
   172	}
   173	
   174	int chcr_uld_rx_handler(void *handle, const __be64 *rsp,
   175				const struct pkt_gl *pgl)
   176	{
   177		struct uld_ctx *u_ctx = (struct uld_ctx *)handle;
   178		struct chcr_dev *dev = u_ctx->dev;
   179		const struct cpl_fw6_pld *rpl = (struct cpl_fw6_pld *)rsp;
   180	
   181		if (rpl->opcode != CPL_FW6_PLD) {
   182			pr_err("Unsupported opcode\n");
   183			return 0;
   184		}
   185	
   186		if (!pgl)
   187			work_handlers[rpl->opcode](dev, (unsigned char *)&rsp[1]);
   188		else
   189			work_handlers[rpl->opcode](dev, pgl->va);
   190		return 0;
   191	}
   192	
   193	int chcr_uld_tx_handler(struct sk_buff *skb, struct net_device *dev)
   194	{
 > 195		return chcr_ipsec_xmit(skb, dev);
   196	}
   197	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (30112 bytes)