netdev - Re: [PATCH 26/31] nds32: Build infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEbi=3d=SNk5gWB=JAB3babeyJn1A=GcDK3RChgKMJC+VA3rZw@mail.gmail.com>
Date:   Thu, 16 Nov 2017 18:03:25 +0800
From:   Greentime Hu <green.hu@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Greentime <greentime@...estech.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Networking <netdev@...r.kernel.org>,
        Vincent Chen <vincentc@...estech.com>
Subject: Re: [PATCH 26/31] nds32: Build infrastructure

2017-11-13 18:45 GMT+08:00 Geert Uytterhoeven <geert@...ux-m68k.org>:
> On Wed, Nov 8, 2017 at 11:16 AM, Arnd Bergmann <arnd@...db.de> wrote:
>> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu <green.hu@...il.com> wrote:
>>> --- /dev/null
>>> +++ b/arch/nds32/Kconfig
>>> @@ -0,0 +1,107 @@
>>> +#
>>> +# For a description of the syntax of this configuration file,
>>> +# see Documentation/kbuild/kconfig-language.txt.
>>> +#
>>> +
>>> +config NDS32
>>> +        def_bool y
>>> +       select ARCH_HAS_RAW_COPY_USER
>>> +       select ARCH_WANT_FRAME_POINTERS if FTRACE
>>> +       select ARCH_WANT_IPC_PARSE_VERSION
>>> +       select CLKSRC_MMIO
>>> +       select CLONE_BACKWARDS
>>> +       select TIMER_OF
>>> +       select FRAME_POINTER
>>> +       select GENERIC_ATOMIC64
>>> +       select GENERIC_CPU_DEVICES
>>> +       select GENERIC_CLOCKEVENTS
>>> +       select GENERIC_IOMAP
>>> +       select GENERIC_IRQ_CHIP
>>> +       select GENERIC_IRQ_PROBE
>>> +       select GENERIC_IRQ_SHOW
>>> +       select GENERIC_STRNCPY_FROM_USER
>>> +       select GENERIC_STRNLEN_USER
>>> +       select GENERIC_TIME_VSYSCALL
>>> +       select HAVE_ARCH_TRACEHOOK
>>> +       select HAVE_GENERIC_IOMAP
>>
>> You normally don't want HAVE_GENERIC_IOMAP, at least unless the CPU
>> has special instructions to trigger PCI I/O port access.
>
> GENERIC_IOMAP or HAVE_GENERIC_IOMAP?
>
> The latter doesn't even exist, except in
> Documentation/kbuild/kconfig-language.txt, so it cannot be selected.

Thanks.
I will remove HAVE_GENERIC_IOMAP in the next version patch.

> Given the checks for __NDS32_EB__, NDS32 can be either big or little endian,
> so you should have (excatly one of) CPU_BIG_ENDIAN or CPU_LITTLE_ENDIAN set.

Thanks.
I will check if we need this config or not and update in the next version patch.