netdev - Re: [iproute2 1/1] tipc: change family attribute from u32 to u16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171116160047.20ee5850@xeon-e3>
Date:   Thu, 16 Nov 2017 16:00:47 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jon Maloy <jon.maloy@...csson.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <mohan.krishna.ghanta.krishnamurthy@...csson.com>,
        <tung.q.nguyen@...tech.com.au>, <hoang.h.le@...tech.com.au>,
        <canh.d.luu@...tech.com.au>, <ying.xue@...driver.com>,
        <tipc-discussion@...ts.sourceforge.net>,
        Jiri Pirko <jiri@...lanox.com>
Subject: Re: [iproute2  1/1] tipc: change family attribute from u32 to u16

On Wed, 15 Nov 2017 17:25:44 +0100
Jon Maloy <jon.maloy@...csson.com> wrote:

> commit 28033ae4e0f ("net: netlink: Update attr validation to require
> exact length for some types") introduces a stricter control on attributes
> of type NLA_U* and NLA_S*.
> 
> Since the tipc tool is sending a family attribute of u32 instead of as
> expected u16 the tool is now effectively broken.
> 
> We fix this by changing the type of the said attribute.
> 
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied.

I noticed devlink has the same problem!
devlink/mnlg.c: mnl_attr_put_u32(nlh, CTRL_ATTR_FAMILY_ID, nlg->id);