netdev - Re: [PATCH iproute2/net-next v3]tc: B.W limits can now be specified in %.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171117131258.194d2941@xeon-e3>
Date:   Fri, 17 Nov 2017 13:12:58 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Nishanth Devarajan <ndev2021@...il.com>
Cc:     netdev@...r.kernel.org, doucette@...edu, michel.machado@...il.com
Subject: Re: [PATCH iproute2/net-next v3]tc: B.W limits can now be specified
 in %.

On Sat, 18 Nov 2017 02:13:38 +0530
Nishanth Devarajan <ndev2021@...il.com> wrote:

> diff --git a/tc/tc_util.h b/tc/tc_util.h
> index 583a21a..7b7420a 100644
> --- a/tc/tc_util.h
> +++ b/tc/tc_util.h
> @@ -24,14 +24,14 @@ struct qdisc_util {
>  	struct  qdisc_util *next;
>  	const char *id;
>  	int (*parse_qopt)(struct qdisc_util *qu, int argc,
> -			  char **argv, struct nlmsghdr *n);
> +			  char **argv, struct nlmsghdr *n, char *dev);

One more nit...
Since parsing queue options should not modify the device name, that should
be const char *.