netdev - Re: [PATCH net-next] dt-bindings: net: dsa: Document additional Microchip KSZ family switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Nov 2017 04:57:05 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Tristram.Ha@...rochip.com
Cc:     "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Pavel Machek <pavel@....cz>, UNGLinuxDriver@...rochip.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] dt-bindings: net: dsa: Document additional
 Microchip KSZ family switches

> +		ksz9477: ksz9477@0 {
> +			compatible = "microchip,ksz9477";
> +			reg = <0>;
>  
> -                                                             spi-max-frequency = <44000000>;
> -                                                             spi-cpha;
> -                                                             spi-cpol;
> +			spi-max-frequency = <44000000>;
> +			spi-cpha;
> +			spi-cpol;

...

> +
> +		};
> +		ksz8794: ksz8794@0 {
> +			compatible = "microchip,ksz8794";
> +			reg = <0>;
> +
> +			spi-max-frequency = <30000000>;
> +			spi-cpha;
> +			spi-cpol;
> +
> +			};

...

> +		};
> +		ksz8864: ksz8864@0 {
> +			compatible = "microchip,ksz8864";
> +			reg = <0>;
> +
> +			spi-max-frequency = <12000000>;
> +			spi-cpha;
> +			spi-cpol;
> +
...
> +		};
> +	};

Hi Tristram

Nitpick. These all appear to be on the same SPI bus. So they should
have different reg values.

Also, the label is supposed to be generic, not specific. So switch0:
ksz9477@0, switch1: ksz8794@1, etc.

	   Andrew