netdev - Re: [PATCH v2] net: qcom/emac: extend DMA mask to 46bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <643046e7-4a6a-7f52-5104-5d7dea675b43@codeaurora.org>
Date:   Fri, 17 Nov 2017 08:24:46 -0600
From:   Timur Tabi <timur@...eaurora.org>
To:     Wang Dongsheng <wdsch86@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: qcom/emac: extend DMA mask to 46bits

On 11/17/17 3:56 AM, Wang Dongsheng wrote:
> -#define TPD_BUFFER_ADDR_H_SET(tpd, val)	BITS_SET((tpd)->word[3], 18, 30, val)
> +#define TPD_BUFFER_ADDR_H_SET(adpt, tpd, val)	BITS_SET((tpd)->word[3], 18, \
> +						TX_TS_ENABLE & \
> +				readl((adpt)->csr + EMAC_EMAC_WRAPPER_CSR1) ? \
> +						30 : 31, val)

NAK.

Sorry, but this is terrible.  Every write to the TPD forces a secret 
read from another register?  No thank you.

Just do what you had in v1, but also set the DMA mask.  Add a comment 
saying that we can support 46 bits because we never enable timestamping.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.