netdev - Re: [PATCH net] sctp: report SCTP_ERROR_INV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADvbK_etQ8rUA-QaihvY34OZ_k+t5JbdGTn4Cm0CW1RGA=4pLg@mail.gmail.com>
Date:   Sun, 19 Nov 2017 02:20:04 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        davem <davem@...emloft.net>, Neil Horman <nhorman@...driver.com>
Subject: Re: [PATCH net] sctp: report SCTP_ERROR_INV_STRM as cpu endian

On Fri, Nov 17, 2017 at 11:04 PM, Marcelo Ricardo Leitner
<marcelo.leitner@...il.com> wrote:
> On Fri, Nov 17, 2017 at 02:15:02PM +0800, Xin Long wrote:
>> rfc6458 demands the send_error in SCTP_SEND_FAILED_EVENT should
>> be in cpu endian, while SCTP_ERROR_INV_STRM is in big endian.
>>
>> This issue is there since very beginning, Eric noticed it by
>> running 'make C=2 M=net/sctp/'.
>>
>> This patch is to convert it before reporting it.
>
> Unfortunatelly we can't fix this as this will break UAPI. It will
> break applications that are currently matching on the current value.
yes, you're right, seems all other send_errors also come in big endian now.

what do you think of using:
sctp_chunk_fail(ch, (__force __u16)SCTP_ERROR_INV_STRM); or

sctp_chunk_fail(ch, (__force __u32)SCTP_ERROR_INV_STRM);

to avoid this warning ?

>
>>
>> Reported-by: Eric Dumazet <eric.dumazet@...il.com>
>> Signed-off-by: Xin Long <lucien.xin@...il.com>
>> ---
>>  net/sctp/stream.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/sctp/stream.c b/net/sctp/stream.c
>> index a11db21..f86ceee 100644
>> --- a/net/sctp/stream.c
>> +++ b/net/sctp/stream.c
>> @@ -64,7 +64,7 @@ static void sctp_stream_outq_migrate(struct sctp_stream *stream,
>>                */
>>
>>               /* Mark as failed send. */
>> -             sctp_chunk_fail(ch, SCTP_ERROR_INV_STRM);
>> +             sctp_chunk_fail(ch, be16_to_cpu(SCTP_ERROR_INV_STRM));
>>               if (asoc->peer.prsctp_capable &&
>>                   SCTP_PR_PRIO_ENABLED(ch->sinfo.sinfo_flags))
>>                       asoc->sent_cnt_removable--;
>> --
>> 2.1.0
>>